PR-1b: shim renames — CudaRenderShim → RenderShim, LowerScanPipelineShim → LowerKernelBodyShim#77
Merged
Conversation
…LowerKernelBodyShim Target-agnostic naming for two kernel-pipeline shims, per docs/phase_decomposition_redesign.md section 3.3.3. - CudaRenderShim -> RenderShim (name='cuda_render' -> 'render') Drops hardcoded 'Cuda' in the shim name; PR-1c will add the target kwarg the shim reads to dispatch. - LowerScanPipelineShim -> LowerKernelBodyShim (name='lower_scan_pipeline' -> 'lower_kernel_body') The legacy lower_scan_pipeline function name is historical from M1; the SHIM that wraps it should describe the role, not the legacy function. Underlying lower_scan_pipeline helper is unchanged. Pure rename: no behavior, no logic changes. Full byte-equivalence harness (test_runner_byte_equivalence.py + test_byte_equivalence_jit.py + test_cuda_complete_runner.py — 532 fixtures) passes unchanged. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced May 19, 2026
One-line mechanical re-sort — ep_has_work_stealing import moves into the alphabetical block. Pre-existing ruff failure on design/redesign-package blocks PR-1b CI; inlined here so the PR goes CLEAN without a separate chore-PR dependency. No behavior change. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Second of 5 splits of the original PR-1. Mechanical rename pass: pipeline shim names become target-agnostic so PR-1c's
targetkwarg + future non-CUDA targets fit cleanly.CudaRenderShim(name='cuda_render')RenderShim(name='render')targetthrough; class shouldn't hardcode CUDALowerScanPipelineShim(name='lower_scan_pipeline')LowerKernelBodyShim(name='lower_kernel_body')lower_scan_pipelinefunction name (which dates to M1)Files touched (6)
src/srdatalog/ir/default_pipelines.py— class defs,name=args,DEFAULT_KERNEL_PIPELINE,__all__, assertions, docstringssrc/srdatalog/ir/codegen/cuda/api.py— 1 assertion messagesrc/srdatalog/ir/dialects/relation/sorted_array/lowerings/lower_mir_execute_pipeline.py— docstring refstests/test_default_pipelines_shims.py— imports, pipeline-order assertions, 2 test renamestests/test_lower_mir_execute_pipeline_byte_equivalent.py— docstring/comment refstests/test_verify_renderability.py— pipeline-order assertion test, comments, 1 test rename49 insertions / 49 deletions = 98 LOC.
Test plan
grep CudaRenderShim\|LowerScanPipelineShim src/srdatalog tests examplesreturns 0 hitsOut of scope (later splits)
Compiler.run(target=)kwarg threading)CudaRenderCtxfromLoweringCtx)Cross-PR conflict expectations
pyproject.toml+core/plugin.py)targetkwarg threading throughRenderShim— clean addition🤖 Generated with Claude Code